-
Notifications
You must be signed in to change notification settings - Fork 68
[PLT-1490] Removed project.setup #1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
)[0] | ||
empty_ontology = {"tools": [], "classifications": []} | ||
project.setup(editor, empty_ontology) | ||
def project_with_one_feature_ontology(project, client: Client): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can not have ontologies with no features and use the connect_ontology method
|
||
|
||
@pytest.fixture | ||
def video_ontology(client: Client): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to make a specific video ontology with the correct features. Since you can not have ontologies anymore with all features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also might move away from not having a media type specified with ontology
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a story for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point ill write a ticket. But I think we should I was talking to perception and we have had issues revolving around media types not being in ontologies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor questions... but the issues is tests failing for pythong 3.12 (latest code)
@@ -118,18 +118,174 @@ def ontology(): | |||
"color": "#008941", | |||
"classifications": [], | |||
} | |||
entity_tool = { | |||
raster_segmentation_tool = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this change, i.e. removed entity_tool and segmentation_tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh so regular masks (raster-segmentation) are here I just removed super pixel because it is not only deprecated but completed removed in the app so no point of making ontologies with it anymore. Entity I had to remove this ontology is meant for images and images don't support entity. The old workflow was to just add every single option to an ontology. You cant really do that anymore with regular connect_editor
|
||
|
||
@pytest.fixture | ||
def video_ontology(client: Client): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need a story for that
Description