Skip to content

[PLT-1490] Removed project.setup #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 26, 2024
Merged

[PLT-1490] Removed project.setup #1843

merged 9 commits into from
Sep 26, 2024

Conversation

Gabefire
Copy link
Collaborator

@Gabefire Gabefire commented Sep 24, 2024

Description

  • Removed project.setup and migrated tests to connect_ontology

@Gabefire Gabefire requested a review from a team as a code owner September 24, 2024 18:56
@Gabefire Gabefire added the hold do not review yet! label Sep 24, 2024
@Gabefire Gabefire marked this pull request as draft September 24, 2024 19:59
)[0]
empty_ontology = {"tools": [], "classifications": []}
project.setup(editor, empty_ontology)
def project_with_one_feature_ontology(project, client: Client):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not have ontologies with no features and use the connect_ontology method

@Gabefire Gabefire changed the title [PLT-1490] Remove .setup part 1 [PLT-1490] Removed project.setup Sep 25, 2024
@Gabefire Gabefire removed the hold do not review yet! label Sep 25, 2024
@Gabefire Gabefire marked this pull request as ready for review September 25, 2024 03:23


@pytest.fixture
def video_ontology(client: Client):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to make a specific video ontology with the correct features. Since you can not have ontologies anymore with all features

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also might move away from not having a media type specified with ontology

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a story for that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point ill write a ticket. But I think we should I was talking to perception and we have had issues revolving around media types not being in ontologies

Copy link
Contributor

@vbrodsky vbrodsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor questions... but the issues is tests failing for pythong 3.12 (latest code)

@@ -118,18 +118,174 @@ def ontology():
"color": "#008941",
"classifications": [],
}
entity_tool = {
raster_segmentation_tool = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change, i.e. removed entity_tool and segmentation_tool

Copy link
Collaborator Author

@Gabefire Gabefire Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh so regular masks (raster-segmentation) are here I just removed super pixel because it is not only deprecated but completed removed in the app so no point of making ontologies with it anymore. Entity I had to remove this ontology is meant for images and images don't support entity. The old workflow was to just add every single option to an ontology. You cant really do that anymore with regular connect_editor



@pytest.fixture
def video_ontology(client: Client):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a story for that

@Gabefire Gabefire merged commit 37b7b12 into v6 Sep 26, 2024
18 of 26 checks passed
@Gabefire Gabefire deleted the gu/remove_setup_part_1 branch September 26, 2024 21:27
vbrodsky pushed a commit that referenced this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants